Skip to content

Ground-up Rewrite of Blast Furnace

Ceikry requested to merge Ceikry/2009scape-dev:bf-rewrite-tdd into master

What have you done in this MR?

  • Completely axed the old implementation and replaced it with a TDD-developed implementation.

Testers:

  • Most things are already unit tested completely (meaning the actual internal logic is already thoroughly and automatically tested), the only thing you really need to test is to get in and play it, make sure the animations look ok, etc.

Source used for almost the entire implementation: https://runescape.wiki/w/Blast_Furnace?oldid=2078799

Closes #1057 (closed) Closes #1428 (closed) Closes #1076 Closes #1474 Closes #1024 (closed)

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Ceikry

Merge request reports