Fix Fight Arena Jeremy Servil Missing
What have you done in this MR?
Resolves #1444 (closed)
- Fixed Jeremy Servil permanently disappearing after the cutscene when you show Jeremy in his cell you have the keys
The issue: Jeremy Servil is suppose to walk out of his cell and say "I'll run ahead." The cutscene was setup to do this part of him walking out of the cell in the open world. Szu when originally creating the cutscene attempts to teleport the regular world Jeremy back to his cell but does it AFTER loading a new region trapping the real open world Jeremy inside a cutscene and he gets deleted when the cutscene ends. This results in Jeremy not being available in the world for other players after the cutscene is triggered.
The fix: I moved the line which teleports Jeremy back to his cell BEFORE the new cutscene region is created. The cutscene is not perfect and could use some work but this fixes the issue of Jeremy getting deleted so he is always available in the open world for other players.
Are there any tricky things testers should keep an eye out for?
-
No -
Yes, as follows:
::setqueststage 61 88
Then talk to Jeremy in his cell and complete all the cutscenes. You should find Jeremy in his cell and not missing after finishing all the fight cutscenes.
-
I have tested these changes thoroughly. -
This requires extra testing due to changes to architecture or other similarly risky changes. -
I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes. -
I acknowledge that this contribution will be released under the AGPL license.
*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***