Skip to content

Fixed books interface by splitting the pageSetup into 2 steps

Oven Bread requested to merge ovenbreado/2009scape:books-init-split into master

What have you done in this MR?

  • Corrected how the book interface should be called.

Techinical: I've split the init interface call into openBook and pageSetup. Call openBook for the first init, call pageSetup for all other pages.

I've also added a flag to set pagination to true/false and a model setter for each line. These do not need to be tested as they are not in use for the time being.

  • No
  • Yes, as follows:

Test that books work as usual

  • Baxtorian Book
  • ::stats command
  • Any book of your choice at random

Nothing should change.

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Oven Bread

Merge request reports