Skip to content

Immersive sound update 1

Zerken requested to merge Zerken/2009-scape-zerken:immersive-sound-update-1 into master

What have you done in this MR?

  • Implemented water filling sounds for filling water vessils(buckets, bowls, jugs, vials....) from all water sources
  • Implemented specific bucket water filling sound when filling from a well
  • Implemented emptying sounds for emptying vessils(buckets, bowls, jugs, vials....)
  • Implemented cow milking sound
  • Implemented sound when smelting at a furnace
  • Implemented sound when smelting cannonballs at a furnace
  • Implemented sound when glassblowing
  • Fixed herb cleaning sound
  • Fixed regular wood door opening and closing sounds
  • Implemented metal door/gate opening and closing sounds
  • Implemented fence opening and closing sounds
  • Added Camelot castle main gate(id 26081, 26082) config in door_configs.json
  • Fixed Sinclair mansion main gate (Id 26130) to be a metal type door in door_configs.json
  • Implemented drinking sound when drinking from a waterskin in the desert
  • Implemented desert magic carpet travel take off and landing sound
  • Implemented desert magic carpet travel jingle/music
  • Resolved #1173 (closed). Fence(Fence around Falador cow farm) id 7049 is now properly identified as a fence and fence id 7050 now has the correct open door id in door_configs.json so it opens correctly
  • Fence id 34780 is now properly identified as a fence in door_configs.json so it opens correctly
  • Fence id 8810 is now properly identified as a fence in door_configs.json so it opens correctly
  • Fence id 2050-2051 is now properly identified as a fence in door_configs.json so it opens correctly
  • Fence id 1553 now has the correct open id in door_configs.json so it opens correctly
  • Fixed music tracks Relleka(289), Saga(290), and Borderlands(291) so they now play in their correct locations
  • Implemented jingle/music for sailing/chartering a ship(Trader crewmembers)
  • Implemented jingle/music for sailing/chartering a ship from/to Port Sarim/Karamja
  • Implemented jingle/music for sailing/chartering a ship from/to Port Sarim/Entrana
  • Implemented jingle/music for sailing/chartering a ship from/to Relleka/Neitiznot
  • Implemented jingle/music for sailing/chartering a ship from/to Relleka/Jatizso
  • Implemented jingle/music for sailing/chartering a ship from/to Ardougne/Brimmhaven
  • Implemented jingle/music for sailing/chartering a ship from/to Port Sarim/Pest control
  • Fixed the music player to be more authentic. Now when songs end they will repeat instead of playing a random inauthentic song. The loop function now works correctly so the currently playing song will play endlessly on repeat regardless of where you go until you turn the loop function back off and enter a new song area.
  • Implemented playJingle function in contentAPI.kt

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Zerken

Merge request reports