Skip to content

Death Plateau Quest Implementation

Oven Bread requested to merge ovenbreado/2009scape:death-plateau-continued into master

What have you done in this MR?

Shoutout to @bushtail and others who did the previous MR :)

  • Implemented Death Plateau
  • Copied @bushtail !938 (closed) initial Death Plateau implementation in. One thing to note:
  • There is a NPC dialogue kt (DenulthDialogue.kt)
  • There is a NPC quest dialogue file kt (DenulthDialogueFile.kt) The idea behind here is that DenulthDialogue is the main entry point for the NPC and when the questStage is within a certain quest, the dialogue is redirected to a DialogueFile. ^ This will be super important for other quests that depend on the same NPC. I found it confusing to include ALL the dialogue into one file placed under the quest file for that NPC.

Closes #810 (closed) Closes #700 (closed)

Otherwise, used the shit out of ContentAPI and MapArea. Are there any tricky things testers should keep an eye out for?

  • No
  • Yes, as follows:

2009 Video Source: https://www.youtube.com/watch?v=ihmx2Cwr3uc Full quest, start to end.

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Oven Bread

Merge request reports